Skip to content

Update adafruit_ble_radio.py #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Update adafruit_ble_radio.py #22

merged 2 commits into from
Feb 18, 2022

Conversation

infamy
Copy link

@infamy infamy commented Feb 10, 2022

Fix missing timeout param documentation for receive. (present is receive_full but not receive).

Fix missing timeout param documentation for receive. (present is receive_full but not receive).
@infamy
Copy link
Author

infamy commented Feb 10, 2022

Well that's a super cryptic CI failure... any hints? This is just adding a line to improve the docs.

@tekktrik
Copy link
Member

tekktrik commented Feb 12, 2022

It looks like black is wanting to reformatting one of the files. You can fix it using pre-commit by following the instructions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code Let me know if I can help with anything! That should fix the CI error.

@tekktrik tekktrik requested a review from a team February 12, 2022 02:38
@askpatrickw
Copy link

@infamy do you need any help finishing up this PR?

@infamy
Copy link
Author

infamy commented Feb 17, 2022 via email

Copy link

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the formatter and pushed the result to this branch and it's passing now.

This change looks good to me. Thanks for the docs improvement @infamy.

@FoamyGuy FoamyGuy merged commit b22022d into adafruit:main Feb 18, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 18, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.10 from 1.0.9:
  > Fixed readthedocs build
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#11 from tammymakesthings/issue9-add-type-annotations
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.11 from 1.2.10:
  > Fixed readthedocs build
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#35 from tammymakesthings/issue32-add-type-annotations
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#27 from tekktrik/doc/reveal-gain-class
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#25 from tammymakesthings/update-requirements-for-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.8 from 1.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#5 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.3 from 4.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#51 from lstein/decode-bug-fix
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.1 from 0.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#22 from infamy/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants